Copilot commented on code in PR #12995: URL: https://github.com/apache/trafficserver/pull/12995#discussion_r2963068076
########## plugins/experimental/jax_fingerprint/header.h: ########## @@ -0,0 +1,32 @@ +/** @file + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + + */ + +#pragma once + +#include "ts/ts.h" + +void append_header(TSHttpTxn txnp, const std::string &header, const std::string &fingerprint); +void append_via_header(TSHttpTxn txnp, const std::string &via_header); +void set_header(TSHttpTxn txnp, const std::string &header, const std::string &fingerprint); +void set_via_header(TSHttpTxn txnp, const std::string &via_header); +void remove_header(TSHttpTxn txnp, const std::string &header); +bool has_header(TSHttpTxn txnp, const std::string &header); Review Comment: `header.h` declares functions taking `std::string` but doesn't include `<string>`. This header is included from `plugin.cc` before any `<string>` include, so it can fail to compile depending on transitive includes. Add `#include <string>` to make the header self-contained. ########## plugins/experimental/jax_fingerprint/userarg.h: ########## @@ -0,0 +1,32 @@ +/** @file + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + + */ + +#pragma once + +#include "context.h" + +#include "ts/ts.h" + +int reserve_user_arg(PluginConfig &config); +void fill_user_arg_index(PluginConfig &config); +void set_user_arg(void *container, PluginConfig &config, JAxContext *ctx); +JAxContext *get_user_arg(void *container, PluginConfig &config); Review Comment: `userarg.h` declares functions that take `PluginConfig&`, but `PluginConfig` is neither declared nor included here. This makes the header non-self-contained and will fail to compile if included without `config.h` first. Add `#include "config.h"` or forward-declare `struct PluginConfig;` in this header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
