maskit commented on code in PR #12995: URL: https://github.com/apache/trafficserver/pull/12995#discussion_r2977624065
########## plugins/experimental/jax_fingerprint/config.h: ########## @@ -0,0 +1,69 @@ +/** @file + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + + */ + +#pragma once + +#include "ts/ts.h" +#include "method.h" + +#include <string> +#include <unordered_set> + +enum class Mode : int { + OVERWRITE, + KEEP, + APPEND, +}; + +enum class PluginType : int { + GLOBAL, + REMAP, +}; + +// This hash function enables looking up the set by a string_view without making a temporary string object. +struct StringHash { + // Enable heterogeneous lookup + using is_transparent = void; + + size_t + operator()(std::string_view sv) const + { + return std::hash<std::string_view>{}(sv); + } +}; + +struct PluginConfig { + PluginConfig() { Dbg(dbg_ctl, "New config (%p) has been created", this); } + ~PluginConfig() { Dbg(dbg_ctl, "Config for (%p) has been deleted", this); } Review Comment: Fixed ########## plugins/experimental/jax_fingerprint/CMakeLists.txt: ########## @@ -0,0 +1,52 @@ +####################### +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor license +# agreements. See the NOTICE file distributed with this work for additional information regarding +# copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed under the License +# is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express +# or implied. See the License for the specific language governing permissions and limitations under +# the License. +# +####################### + +add_atsplugin( + jax_fingerprint + plugin.cc + context.cc + userarg.cc + header.cc + log.cc + ja3/ja3_method.cc + ja3/ja3_utils.cc + ja4/ja4_method.cc + ja4/ja4.cc + ja4/tls_client_hello_summary.cc + ja4h/ja4h_method.cc + ja4h/ja4h.cc + ja4h/datasource.cc +) +target_link_libraries(jax_fingerprint PRIVATE OpenSSL::Crypto OpenSSL::SSL) +verify_global_plugin(jax_fingerprint) + +if(BUILD_TESTING) + add_executable( + test_jax + ja3/test_ja3.cc + ja3/ja3_utils.cc + ja4/test_ja4.cc + ja4/ja4.cc + ja4/tls_client_hello_summary.cc + ja4h/test_ja4h.cc + ja4h/ja4h.cc + ja4h/datasource.cc + ) + target_link_libraries(test_jax PRIVATE Catch2::Catch2WithMain OpenSSL::SSL) Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
