Copilot commented on code in PR #13017:
URL: https://github.com/apache/trafficserver/pull/13017#discussion_r2977915451
##########
tests/autest-parallel.py.in:
##########
@@ -672,6 +726,20 @@ def print_summary(results: List[TestResult],
total_duration: float, expected_tim
print(details[test_name])
print("-" * 70)
+ worker_diagnostics = [
+ r for r in results
+ if r.output and (r.exceptions > 0 or (r.return_code != 0 and r.failed
== 0 and not r.failed_tests))
Review Comment:
`worker_diagnostics` filtering misses several non-attributed worker failures
because it requires `r.failed == 0`. For example, `run_worker()` sets `failed =
len(tests)` on `TimeoutExpired` / `KeyboardInterrupt` / generic `Exception` but
does not populate `failed_tests`, so these cases won’t print any diagnostics
even though the failure isn’t tied to specific tests. Consider keying this
condition off `not r.failed_tests` (and `return_code != 0`) rather than `failed
== 0`, or explicitly including the timeout/interrupt/error paths.
```suggestion
if r.output and (r.exceptions > 0 or (r.return_code != 0 and not
r.failed_tests))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
