Copilot commented on code in PR #13068:
URL: https://github.com/apache/trafficserver/pull/13068#discussion_r3048040902
##########
tools/hrw4u/src/hrw_symbols.py:
##########
@@ -231,13 +231,14 @@ def repl(match: re.Match) -> str:
return repl
- def _handle_set_rm_operation(self, cmd: str, toks: list[str], prefix: str,
qualifier: str, context: str) -> str:
+ def _handle_set_rm_operation(
+ self, cmd: str, toks: list[str], prefix: str, qualifier: str,
context: str, section: SectionType | None = None) -> str:
Review Comment:
`context` is part of the `_handle_set_rm_operation()` signature but is not
used in the function body. Since this method was just modified, consider
removing the parameter (or renaming it to `_context`) to avoid misleading
future readers and to keep the signature minimal.
```suggestion
self, cmd: str, toks: list[str], prefix: str, qualifier: str,
_context: str, section: SectionType | None = None) -> str:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
