maskit opened a new pull request, #13072:
URL: https://github.com/apache/trafficserver/pull/13072
Key changes:
- datasource abstraction (JA4/JA4H) — provides accessor-based access to
ClientHello fields, avoiding unnecessary copies into a summary object.
- Eliminated temporary std::string allocations — helpers now write directly
into caller-provided buffers and return std::string_view where possible. SHA256
hashing is done incrementally instead of materializing intermediate strings.
- Small-array optimization — ciphers and extensions use stack storage for
typical ClientHellos, falling back to heap only for unusually large ones.
- ja4_common/ — shared utilities extracted for JA4 and JA4H.
- Simplified headers — moved implementation details out of ja4.h; extracted
tls_client_hello_summary.h as its own header.
- Namespace cleanup — organized under proper namespaces.
Each subdirectory (ja3/, ja4/, ja4h/) now follows a consistent structure:
method.cc/.h for the fingerprint method, test.cc for tests, plus
algorithm-specific files. Redundant prefixes removed since subdirectories
provide context.
Tests updated to match. No functional changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
