bneradt commented on code in PR #13059: URL: https://github.com/apache/trafficserver/pull/13059#discussion_r3067241677
########## src/proxy/logging/CMakeLists.txt: ########## @@ -54,6 +54,10 @@ if(BUILD_TESTING) target_compile_definitions(test_RolledLogDeleter PRIVATE TEST_LOG_UTILS) target_link_libraries(test_RolledLogDeleter tscore ts::inkevent records Catch2::Catch2WithMain) add_catch2_test(NAME test_RolledLogDeleter COMMAND test_RolledLogDeleter) + + add_executable(test_LogAccess unit-tests/test_LogAccess.cc) + target_link_libraries(test_LogAccess ts::logging ts::http ts::inkevent records Catch2::Catch2WithMain) Review Comment: True. We can get rid of `ts:http` now, but that was indirectly pulling in `ts::configmanager` which is needed. Replacing it with `ts::configmanager`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
