zwoop commented on code in PR #13061:
URL: https://github.com/apache/trafficserver/pull/13061#discussion_r3088215715
##########
src/iocore/cache/CacheVC.cc:
##########
@@ -479,6 +481,14 @@ CacheVC::handleRead(int /* event ATS_UNUSED */, Event * /*
e ATS_UNUSED */)
f.doc_from_ram_cache = true;
io.aio_result = io.aiocb.aio_nbytes;
+ // Try to promote this object to the RAM cache
+ Doc *doc = reinterpret_cast<Doc *>(buf->data());
+ if (_ram_cache_cutoff_check(doc)) {
+ bool http_copy_hdr = cache_config_ram_cache_compress && doc->hlen;
+ uint64_t o = dir_offset(&dir);
Review Comment:
Yeah, this is real, and needs to be addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]