bneradt commented on code in PR #13134: URL: https://github.com/apache/trafficserver/pull/13134#discussion_r3219404086
########## include/ts/ts.h: ########## @@ -2768,6 +2768,25 @@ TSReturnCode TSHttpTxnCachedRespModifiableGet(TSHttpTxn txnp, TSMBuffer *bufp, T TSReturnCode TSHttpTxnCacheLookupStatusSet(TSHttpTxn txnp, int cachelookup); TSReturnCode TSHttpTxnCacheLookupUrlGet(TSHttpTxn txnp, TSMBuffer bufp, TSMLoc obj); TSReturnCode TSHttpTxnCacheLookupUrlSet(TSHttpTxn txnp, TSMBuffer bufp, TSMLoc obj); + +/** + Gets the effective cache key digest (cryptographic hash) that was + used for cache lookup or storage on this transaction. The digest + is returned as raw bytes — 16 bytes for MD5 (default) or 32 bytes + for SHA-256 (FIPS mode). A buffer of at least 32 bytes is + recommended to accommodate either configuration. + + @param txnp the transaction. + @param buffer caller-provided buffer to receive the raw hash bytes. + If @c nullptr, only @a length is set (size query). + @param length in: capacity of @a buffer in bytes. + out: actual digest size in bytes. Review Comment: `[in]`, `[out]`, `[in,out]` for `@param` please. In case it's helpful, we updated the AGENTS.md file for this: https://github.com/apache/trafficserver/blob/master/AGENTS.md#code-style But that may have landed after you made this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
