Copilot commented on code in PR #13137:
URL: https://github.com/apache/trafficserver/pull/13137#discussion_r3222566706
##########
src/tscore/CMakeLists.txt:
##########
@@ -21,7 +21,7 @@ add_executable(CompileParseRules CompileParseRules.cc)
add_custom_command(
OUTPUT ParseRulesCType ParseRulesCTypeToUpper ParseRulesCTypeToLower
- COMMAND CompileParseRules
+ COMMAND ${CMAKE_COMMAND} -E env ASAN_OPTIONS=detect_leaks=0
$<TARGET_FILE:CompileParseRules>
Review Comment:
This overrides ASAN_OPTIONS for the CompileParseRules invocation, which can
unintentionally drop any user-specified ASan settings (e.g.,
symbolize/abort_on_error/suppressions) during the build. Consider preserving an
existing ASAN_OPTIONS value (e.g., by prefixing detect_leaks=0 to the current
setting) so only leak detection is disabled without clobbering other options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
