JosiahWI commented on code in PR #13182:
URL: https://github.com/apache/trafficserver/pull/13182#discussion_r3276319645
##########
tests/gold_tests/logging/ts_process_handler.py:
##########
@@ -36,7 +36,7 @@ def __init__(self, message):
def get_ts_process_pid(ts_identifier):
processes = []
for proc in psutil.process_iter(['cmdline']):
- commandline = ' '.join(proc.info['cmdline'])
+ commandline = ' '.join(proc.info.get('cmdline') or [])
Review Comment:
Would a typical Python dev understand at a glance what's going on here? You
could use the default value for `get` to make this more conventional for Python.
```suggestion
commandline = ' '.join(proc.info.get('cmdline', [])
```
##########
tests/gold_tests/redirect/.gitignore:
##########
@@ -1 +1,3 @@
generated_test_data/
Review Comment:
Should `generated_test_data` be removed from .gitignore now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
