Copilot commented on code in PR #13195:
URL: https://github.com/apache/trafficserver/pull/13195#discussion_r3291466892
##########
include/cripts/Urls.hpp:
##########
@@ -338,15 +339,17 @@ class Url
cripts::string_view GetSV() override;
cripts::string operator+=(cripts::string_view add);
- self_type operator=(cripts::string_view path);
+ self_type &operator=(cripts::string_view path);
String operator[](Segments::size_type ix);
void
Erase(Segments::size_type ix)
{
auto p = operator[](ix);
Review Comment:
`Path::Erase(Segments::size_type ix)` can dereference a null `String` owner
when `ix` is out of range: `operator[](ix)` returns a default `String` (without
`_owner` set) if `ix >= segments.size()`, and the subsequent `p.operator=("")`
will dereference `_owner` inside `String::operator=`. Please add an explicit
bounds check / assertion before calling `p.operator=`, or make `operator[]`
always return a valid `String` (e.g., by clamping/asserting).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
