maskit commented on code in PR #13197:
URL: https://github.com/apache/trafficserver/pull/13197#discussion_r3305044356
##########
src/iocore/net/TLSCertCompression.cc:
##########
@@ -48,25 +46,41 @@ constexpr unsigned int N_ALGORITHMS = 3;
struct alg_info {
const char *name;
int32_t number;
+ bool available;
#if HAVE_SSL_CTX_ADD_CERT_COMPRESSION_ALG
ssl_cert_compression_func_t compress_func;
ssl_cert_decompression_func_t decompress_func;
#endif
} supported_algs[] = {
{"zlib", 1,
+#if HAVE_SSL_CTX_ADD_CERT_COMPRESSION_ALG || !defined(OPENSSL_NO_ZLIB)
Review Comment:
Can't we surround the entire entry `HAVE_SSL_CTX_ADD_CERT_COMPRESSION_ALG ||
!(defined(OPENSSL_NO_ZLIB)` instead of adding `available` flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
