bneradt commented on code in PR #13186:
URL: https://github.com/apache/trafficserver/pull/13186#discussion_r3319119450


##########
include/iocore/net/quic/QUICStreamAdapter.h:
##########
@@ -39,6 +39,7 @@ class QUICStreamAdapter
 
   virtual int64_t    write(QUICOffset offset, const uint8_t *data, uint64_t 
data_length, bool fin) = 0;
   Ptr<IOBufferBlock> read(size_t len);
+  void               consume(size_t len);
   virtual bool       is_eos()     = 0;

Review Comment:
   Fixed. The test helper now calls `consume(nread)` after copying bytes out of 
the `QUICStreamAdapter`, so the test path matches the intended read/consume 
contract.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to