phongn commented on PR #13210: URL: https://github.com/apache/trafficserver/pull/13210#issuecomment-4569861885
Thanks for the review. Addressed in 30aa774: the test output buffers were allocated as `*_dstlen() + 1`, but those helpers already include the trailing NUL, so the extra byte would have masked a one-byte overwrite at the documented bound. They now allocate exactly the `dstlen`-reported size (verified the encoder/decoder write their NUL at `dstlen - 1`, so the tests still pass clean in both a normal and an `-DENABLE_ASAN=ON` build). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
