Copilot commented on code in PR #13215:
URL: https://github.com/apache/trafficserver/pull/13215#discussion_r3325379204
##########
plugins/slice/Data.h:
##########
@@ -94,6 +94,8 @@ struct Data {
bool m_prefetchable{false};
+ int64_t m_prefetch_hwm{-1}; // highest block this request has scheduled for
prefetch
Review Comment:
`m_prefetch_hwm` is declared as `int64_t`, but `schedule_prefetch()` uses
`int` block numbers (and `BgBlockFetch::schedule()` also takes `int`). This
introduces an implicit narrowing conversion at `nextblocknum =
data->m_prefetch_hwm + 1;` that can trigger `-Wconversion` /
`-Wsign-conversion` warnings (often treated as errors) and is inconsistent with
the rest of the prefetch block-number plumbing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
