bneradt commented on code in PR #13213:
URL: https://github.com/apache/trafficserver/pull/13213#discussion_r3327312931
##########
src/iocore/net/quic/QUICStream.cc:
##########
@@ -122,15 +136,41 @@ QUICStream::send_data(quiche_conn *quiche_con)
if (len <= 0) {
return;
}
- Ptr<IOBufferBlock> block = this->_adapter->read(len);
- if (this->_adapter->total_len() == this->_sent_bytes + block->size()) {
- fin = true;
+
+ if (!this->_pending_send_block) {
+ this->_pending_send_block = this->_adapter->read(len);
+ if (!this->_pending_send_block) {
+ this->_adapter->encourge_write();
+ return;
Review Comment:
Fixed. QUICStream::has_data_to_send() now treats EOS with all bytes sent but
no FIN as pending output, and QUICStream::send_data() sends a zero-length
STREAM frame with FIN for that case while tracking _sent_fin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
