masaori335 opened a new pull request, #13223: URL: https://github.com/apache/trafficserver/pull/13223
Seven boolean/counter fields were declared dINT, but their marshal functions write a single int, and proxy_protocol_version (ppv) was declared dINT while it actually marshals a string. The dINT type wrongly excludes these fields from log filters and aggregates, and the ppv mislabeling misrepresents variable-length string bytes as two fixed ints to any type-driven consumer. Retype the single-int fields as sINT and ppv as STRING so the declared type matches what each marshal function emits. What happens on mismatch - the field can't be used in a filter (dINT rejected) - can't be aggregated (requires sINT). So fields like cqssl (is-client-SSL, a clean 0/1) were silently un-filterable I'm going to introduce a new binary logging format with self description of type, it depends on this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
