JosiahWI commented on code in PR #13170:
URL: https://github.com/apache/trafficserver/pull/13170#discussion_r3342188602
##########
src/tscore/ink_queue.cc:
##########
@@ -222,10 +251,13 @@ freelist_new(InkFreeList *f)
{
head_p item;
head_p next;
- int result = 0;
+ bool result = false;
+
+ std::lock_guard guard{f->m};
+
+ item = f->head.load();
Review Comment:
This is not a bad idea, but I think the FreeList benchmark stresses this
logic heavily and is sufficient validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
