zwoop commented on PR #13202:
URL: https://github.com/apache/trafficserver/pull/13202#issuecomment-4607603401
@maskit I removed the SSL_get_ex_data stuff, it does reduce the number of
reallocations, but it's pretty marginal impact on performance (maybe 1
microsecond / connection).
The performance on the BIO buffer is real though, I benchmarked it again,
and still get a 15% performance improvement:
## ATS master
| Run | Req/sec | Bytes/sec | Reqs (200 OK) | Total | Avg Size | Errors |
p50 (ms) | Duration |
|-----|---------|-----------|---------------|-------|----------|--------|----------|----------|
| 1 | 522769 | 164.5 MB/s | 23.547M | 23.547M | 315 B | 0.00% | 2.22 | 45.0s
|
### Timing (ms)
| Metric | Latency | TTFB | Connect |
|--------|--------:|--------:|--------:|
| Min | 0.455 | 0.452 | 0.445 |
| μ (Mean) | 2.87 | 2.86 | 5.86 |
| σ (StdDev) | 1.41 | 1.41 | 7.11 |
| p50 | 2.22 | 2.21 | 4.72 |
| p95 | 5.65 | 5.64 | 8.83 |
| p99 | 7.96 | 7.96 | 43.86 |
| Max | 111.8 | 111.7 | 63.14 |
| Skew (γ₁) | 3.57 | 3.55 | 4.63 |
| Samples | 1.472M | 1.472M | 1.5K |
### Latency Distribution
```
p50 │█ 2.22
p95 │██ 5.65
p99 │██ 7.96
min=0.455 μ=2.87 max=111.8
```
## With BIO buffering
| Run | Req/sec | Bytes/sec | Reqs (200 OK) | Total | Avg Size | Errors |
p50 (ms) | Duration |
|-----|---------|-----------|---------------|-------|----------|--------|----------|----------|
| 1 | 602903 | 189.9 MB/s | 27.161M | 27.161M | 315 B | 0.00% | 1.92 | 45.1s
|
### Timing (ms)
| Metric | Latency | TTFB | Connect |
|--------|--------:|--------:|--------:|
| Min | 0.341 | 0.336 | 0.323 |
| μ (Mean) | 2.48 | 2.48 | 4.96 |
| σ (StdDev) | 1.81 | 1.81 | 4.03 |
| p50 | 1.92 | 1.91 | 4.61 |
| p95 | 4.75 | 4.75 | 8.95 |
| p99 | 6.46 | 6.46 | 10.78 |
| Max | 159.0 | 159.0 | 43.59 |
| Skew (γ₁) | 28.18 | 28.18 | 5.40 |
| Samples | 1.698M | 1.698M | 1.5K |
### Latency Distribution
```
p50 │█ 1.92
p95 │█ 4.75
p99 │█ 6.46
min=0.341 μ=2.48 max=159.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
