Copilot commented on code in PR #13241:
URL: https://github.com/apache/trafficserver/pull/13241#discussion_r3360506315
##########
src/proxy/logging/LogAccess.cc:
##########
@@ -2245,12 +2245,12 @@ LogAccess::marshal_client_req_squid_len_tls(char *buf)
int64_t val = 0;
if (m_client_request) {
- val = m_client_request->length_get() +
m_http_sm->client_request_body_bytes;
+ val = m_client_request->length_get() +
m_data->get_client_request_body_bytes();
}
Review Comment:
These TLS handshake access-log marshalers are now routed through
TransactionLogData, including the non-HttpSM logging path. There are existing
unit tests for non-HttpSM LogAccess behavior, but none that exercise the new
TLS handshake byte fields; adding a test would help prevent regressions (e.g.,
ensure non-HttpSM entries marshal these fields to 0 and remain null-safe).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
