dkgkdfg65 opened a new pull request, #13244: URL: https://github.com/apache/trafficserver/pull/13244
10.2.x is missing the base64-decode bounds fix that's on master (#13210). On 10.2.x ats_base64_decode walks the input in 4-char groups but doesn't guard the tail when the length isn't a multiple of 4, so a crafted non-aligned base64 string reads past the input buffer. checked it actually over-reads on 10.2.x (not just a missing line): built ats_base64_decode with -fsanitize=address on ubuntu:22.04 and fed a non-4-multiple input. pre-fix ASan reports a heap-buffer-overflow READ just past the buffer and aborts; with the master fix cherry-picked it decodes cleanly. the upstream unit test (test_ink_base64.cc) comes along in the cherry-pick. clean cherry-pick (-x), original author (Phong Nguyen) preserved. happy to rebase if you'd prefer. upstream: https://github.com/apache/trafficserver/commit/1e1dd1aabeef958d3d876296d0411b8250cfbfcb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
