bneradt commented on code in PR #13229: URL: https://github.com/apache/trafficserver/pull/13229#discussion_r3374390368
########## src/iocore/net/OCSPStapling.cc: ########## @@ -949,24 +956,17 @@ ssl_stapling_init_cert(SSL_CTX *ctx, X509 *cert, const char *certname, const cha X509_up_ref(cert); #endif - map->insert(std::make_pair(cert, cinf)); + map->insert(std::make_pair(cert, cinf_ptr.release())); Review Comment: Should the map be changed to take the unique_ptr's? (And thus this would be a std::move rather than a release() here.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
