Copilot commented on code in PR #13245:
URL: https://github.com/apache/trafficserver/pull/13245#discussion_r3374752397
##########
src/iocore/cache/CacheDir.cc:
##########
@@ -1068,7 +1019,7 @@ CacheSync::mainEvent(int event, Event * /* e ATS_UNUSED
*/)
/* Don't sync the directory to disk if its not dirty. Syncing the
clean directory to disk is also the cause of INKqa07151. Increasing
the serial number causes the cache to recover more data than
necessary.
- The dirty bit it set in dir_insert, overwrite and dir_delete_entry
+ The dirty bit it set in dir_insert, overwrite and
Directory::delete_entry
Review Comment:
Minor grammar issue in this updated comment: "The dirty bit it set" should
be "The dirty bit is set".
##########
src/iocore/cache/CacheDir.cc:
##########
@@ -260,7 +260,7 @@ Directory::bucket_length(Dir *b, int s)
int i = 0;
Dir *seg = this->get_segment(s);
#ifdef LOOP_CHECK_MODE
- if (dir_bucket_loop_fix(b, s, this))
+ if (this->bucket_loop_fix(b, s, this))
return 1;
Review Comment:
`Directory::bucket_loop_fix` is now a member function with signature `(Dir
*start_dir, int s)`, but this call still passes the old third `Directory*`
argument. This will not compile when `LOOP_CHECK_MODE` is enabled.
##########
src/iocore/cache/CacheDir.cc:
##########
@@ -733,7 +684,7 @@ Directory::remove(const CacheKey *key, StripeSM *stripe,
Dir *del)
#ifdef LOOP_CHECK_MODE
loop_count++;
if (loop_count > DIR_LOOP_THRESHOLD) {
- if (dir_bucket_loop_fix(dir_bucket(b, seg), s, this))
+ if (this->bucket_loop_fix(dir_bucket(b, seg), s, this))
return 0;
Review Comment:
`Directory::bucket_loop_fix` no longer takes a `Directory*` parameter. This
call still passes a third argument, which will break compilation when
`LOOP_CHECK_MODE` is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
