Copilot commented on code in PR #13250:
URL: https://github.com/apache/trafficserver/pull/13250#discussion_r3380548627
##########
src/iocore/cache/unit_tests/test_CacheDir.cc:
##########
@@ -169,58 +169,58 @@ class CacheDirTest : public CacheInit
#ifdef LOOP_CHECK_MODE
// probe in bucket with loop
rand_CacheKey(&key);
- s1 = key.slice32(0) % vol->segments;
- b1 = key.slice32(1) % vol->buckets;
- dir_corrupt_bucket(dir_bucket(b1, vol->directory.get_segment(s1)), s1,
vol);
- stripe->directory.insert(&key, vol, &dir);
+ s1 = key.slice32(0) % stripe->directory.segments;
+ b1 = key.slice32(1) % stripe->directory.buckets;
+ dir_corrupt_bucket(dir_bucket(b1, stripe->directory.get_segment(s1)),
s1, stripe);
+ stripe->directory.insert(&key, stripe, &dir);
Dir *last_collision = 0;
- vol->directory.probe(&key, vol, &dir, &last_collision);
+ stripe->directory.probe(&key, stripe, &dir, &last_collision);
rand_CacheKey(&key);
- s1 = key.slice32(0) % vol->segments;
- b1 = key.slice32(1) % vol->buckets;
- dir_corrupt_bucket(dir_bucket(b1, vol->directory.get_segment(s1)), s1,
vol);
+ s1 = key.slice32(0) % stripe->directory.segments;
+ b1 = key.slice32(1) % stripe->directory.buckets;
+ dir_corrupt_bucket(dir_bucket(b1, stripe->directory.get_segment(s1)),
s1, stripe);
last_collision = 0;
- vol->directory.probe(&key, vol, &dir, &last_collision);
+ stripe->directory.probe(&key, stripe, &dir, &last_collision);
// overwrite in bucket with loop
rand_CacheKey(&key);
- s1 = key.slice32(0) % vol->segments;
- b1 = key.slice32(1) % vol->buckets;
+ s1 = key.slice32(0) % stripe->directory.segments;
+ b1 = key.slice32(1) % stripe->directory.buckets;
CacheKey key1;
key1.b[1] = 127;
dir1 = dir;
dir_set_offset(&dir1, 23);
- stripe->directory.insert(&key1, vol, &dir1);
- stripe->directory.insert(&key, vol, &dir);
+ stripe->directory.insert(&key1, stripe, &dir1);
+ stripe->directory.insert(&key, stripe, &dir);
key1.b[1] = 80;
- stripe->directory.insert(&key1, vol, &dir1);
- dir_corrupt_bucket(dir_bucket(b1, vol->directory.get_segment(s1)), s1,
vol);
- vol->directory.overwrite(&key, vol, &dir, &dir, 1);
+ stripe->directory.insert(&key1, stripe, &dir1);
+ dir_corrupt_bucket(dir_bucket(b1, stripe->directory.get_segment(s1)),
s1, stripe);
+ stripe->directory.overwrite(&key, stripe, &dir, &dir, 1);
rand_CacheKey(&key);
- s1 = key.slice32(0) % vol->segments;
- b1 = key.slice32(1) % vol->buckets;
+ s1 = key.slice32(0) % stripe->directory.segments;
+ b1 = key.slice32(1) % stripe->directory.buckets;
key.b[1] = 23;
- stripe->directory.insert(&key, vol, &dir1);
- dir_corrupt_bucket(dir_bucket(b1, vol->directory.get_segment(s1)), s1,
vol);
- vol->directory.overwrite(&key, vol, &dir, &dir, 0);
+ stripe->directory.insert(&key, stripe, &dir1);
+ dir_corrupt_bucket(dir_bucket(b1, stripe->directory.get_segment(s1)),
s1, stripe);
+ stripe->directory.overwrite(&key, stripe, &dir, &dir, 0);
rand_CacheKey(&key);
- s1 = key.slice32(0) % vol->segments;
- Dir *seg1 = vol->directory.get_segment(s1);
+ s1 = key.slice32(0) % stripe->directory.segments;
+ Dir *seg1 = stripe->directory.get_segment(s1);
// freelist_length in freelist with loop
- dir_corrupt_bucket(dir_from_offset(vol->header->freelist[s], seg1), s1,
vol);
- vol->directory.freelist_length(s1);
+
dir_corrupt_bucket(dir_from_offset(stripe->directory.header->freelist[s],
seg1), s1, stripe);
Review Comment:
In this LOOP_CHECK_MODE test case, the freelist entry is taken from
`freelist[s]`, but the segment being tested is `s1` (computed just above).
Using `s` here likely corrupts/checks a different segment than intended, which
can make the test less effective or misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
