JosiahWI opened a new pull request, #13254:
URL: https://github.com/apache/trafficserver/pull/13254

   This change reduces a small amount of duplication and introduces meaningful 
function names. I'm cleaning this up now because there are bugs in the log 
rotation logic (I have not filed issues yet), and my hope is that this 
refactoring makes the code easier to understand and review for those bugfixes.
   
   * Extract `Diags::roll_diags_on_filesize`
   
   * Extract `Diags::roll_diags_on_interval`
   
   * Extract `Diags::roll_streams_on_filesize`
   
   * Extract `Diags::roll_streams_on_interval`
   
   * Extract `Diags::remake_logfile`
   
   * Extract `Diags::swap_diagslog`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to