AceMeistr commented on code in PR #13227:
URL: https://github.com/apache/trafficserver/pull/13227#discussion_r3408385692
##########
src/iocore/net/SSLCertLookup.cc:
##########
@@ -233,24 +233,24 @@ ssl_create_ticket_keyblock(const char *ticket_key_path)
SSLCertContext::SSLCertContext(SSLCertContext const &other)
{
+ std::lock_guard<std::mutex> lock(other.ctx_mutex);
Review Comment:
Previously, it was at the last and only protected `ctx = other.ctx` By
moving it to the top, we can protect the copying of all other variables `opt,
userconfig, keyblock, ctx_type` to avoid potential data races
is it too much i just doubt that, does locking them has a negative impact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
