masaori335 commented on code in PR #13296: URL: https://github.com/apache/trafficserver/pull/13296#discussion_r3433934367
########## src/traffic_server/Crash.cc: ########## @@ -146,6 +147,10 @@ crash_logger_init(const char *user) crash_logger_pid = child; crash_logger_fd = pipe[0]; + // Don't leak this socket into later fork+exec children; the logger relies on seeing EOF + // here when we (its parent) exit. + fcntl(crash_logger_fd, F_SETFD, FD_CLOEXEC); Review Comment: Not today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
