bneradt commented on PR #13306: URL: https://github.com/apache/trafficserver/pull/13306#issuecomment-4781709268
One additional issue I noticed: - `tests/gold_tests/tls/tls_post_abort_client.py:67`: the helper treats any response header from ATS as a prompt failure and returns PASS as long as it arrives before the threshold. That can make `tls_origin_post_abort.test.py` pass without exercising the TLS origin reset path: if the origin never starts, the remap breaks, ATS rejects the request before forwarding the body, or the TLS handshake fails immediately, the client still sees `outcome = 'response received'` and passes. Please tighten this so the test proves the intended scenario, for example by checking a 5xx status plus origin-side markers (`request headers received`, `connection reset sent`) and/or requiring some request-body bytes to be sent before the failure. Signed, Codex (GPT-5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
