phongn commented on PR #13233: URL: https://github.com/apache/trafficserver/pull/13233#issuecomment-4783218976
> Change looks good. One optional suggestion: > > in your regression test, you could use `static_assert(CACHE_VALUE_HITS_SIZE(1u, 16384u) > 0.0f, ...)` and similar statements, so that the failures are caught at compile time without running the test. I took the liberty of replacing the old C/C++ preprocessor macros and constants with modern `constexpr` equivalents, in addition to altering the regression test to use `static_assert`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
