Copilot commented on code in PR #13316:
URL: https://github.com/apache/trafficserver/pull/13316#discussion_r3463369344
##########
src/proxy/http2/Http2ConnectionState.cc:
##########
@@ -1494,8 +1494,8 @@ Http2ConnectionState::rcv_frame(const Http2Frame *frame)
// The Http2ClientSession will shutdown because
connection_state.is_state_closed() will be true
} else if (error.cls == Http2ErrorClass::HTTP2_ERROR_CLASS_STREAM) {
if (error.msg) {
- Error("HTTP/2 stream error code=0x%02x client_ip=%s session_id=%"
PRId64 " stream_id=%u %s", static_cast<int>(error.code),
- client_ip, session->get_connection_id(), stream_id, error.msg);
+ Http2StreamDebug(session, stream_id, "HTTP/2 stream error code=0x%02x
client_ip=%s session_id=%" PRId64 " stream_id=%u %s",
+ static_cast<int>(error.code), client_ip,
session->get_connection_id(), stream_id, error.msg);
Review Comment:
`Http2StreamDebug` already prefixes the message with the connection id
(`[session_id]`) and stream id (`[stream_id]`). Keeping `session_id=%...` and
`stream_id=%u` in the formatted message duplicates that data and also requires
passing `stream_id` twice, making this log line noisier than the other
`Http2StreamDebug` calls in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
