masaori335 commented on code in PR #13325: URL: https://github.com/apache/trafficserver/pull/13325#discussion_r3470775788
########## src/proxy/http/HttpSM.cc: ########## @@ -2665,6 +2665,11 @@ HttpSM::state_cache_open_read(int event, void *data) ink_assert(server_entry == nullptr); ink_assert(t_state.cache_info.object_read == nullptr); + // Record the cache open-read completion before state handling can advance + // into cache serving and stamp later transaction milestones. + ATS_PROBE1(milestone_cache_open_read_end, sm_id); + milestones[TS_MILESTONE_CACHE_OPEN_READ_END] = ink_get_hrtime(); + Review Comment: I thought similar. Setting this milestone in the beginning of `CACHE_EVENT_OPEN_READ` case seems makes more sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
