Copilot commented on code in PR #13346:
URL: https://github.com/apache/trafficserver/pull/13346#discussion_r3489148182
##########
src/proxy/http/HttpSM.cc:
##########
@@ -4469,7 +4469,7 @@ HttpSM::tunnel_handler_transform_read(int event,
HttpTunnelProducer *p)
int
HttpSM::tunnel_handler_plugin_agent(int event, HttpTunnelConsumer *c)
{
- STATE_ENTER(&HttpSM::tunnel_handler_plugin_client, event);
+ STATE_ENTER(tunnel_handler_plugin_client, event);
Review Comment:
The probe/log label passed to STATE_ENTER here doesn’t match the actual
handler function name (`tunnel_handler_plugin_agent`). This will emit a
`state_enter_tunnel_handler_plugin_client` probe (and log tag) from
`tunnel_handler_plugin_agent`, which is confusing and makes it harder to
correlate probe names back to code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
