moonchen opened a new pull request, #13366: URL: https://github.com/apache/trafficserver/pull/13366
Backport of #13052. Operators inside an if/endif block never had set_hook() called on them, so _hook retained its default value of TS_HTTP_READ_RESPONSE_HDR_HOOK. When set-status executed at REMAP_PSEUDO_HOOK time, exec() took the response-hook branch and called TSHttpHdrStatusSet on a request buffer, corrupting the header union and crashing. Fix the operator to check TSHttpHdrTypeGet() at runtime instead of trusting get_hook(). Removed _hook and get_hook() from operators. set_hook() becomes is_hook_valid() in Statement and RuleSet to only validate hook compatibility without mutating _hook. Upgrade the HTTPHdr::status_set/reason_set asserts to release_assert so that writing response fields into a request buffer is caught immediately rather than silently corrupting memory. Did not cherry-pick cleanly: three master-only refactors not in 10.1.x touch the same lines (enum class HTTPType in #12249, string_view header accessors in #12243, and the txn/setter overloads for TSHttpHdrStatusSet/TSHttpTxnStatusSet in #12484). Resolved using 10.1.x's existing API surface; the logic change is otherwise identical to master. Not included: the accompanying autest, since the bundle-style replay.yaml test infrastructure it relies on (#12648) isn't in 10.1.x. Verified header_rewrite.so and traffic_server build clean on 10.1.x with this applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
