phongn commented on PR #13257: URL: https://github.com/apache/trafficserver/pull/13257#issuecomment-4916552353
> I think this looks good. I have a couple of concerns. > > 1. Will this build if LZ4 or ZSTD are not found? > 2. I don't think CLFUS is used due to other concerns with the technique. Does this PR resolve those? > > requesting changes just to get answers to the questions. 1. This will build without them, we have CMake-gated preprocessor macros guarding them (also used by the existing LZMA suppot) 2. This PR does _not_ resolve CLFUS issues but I intend to refactor Cache so that compression may be used with any other algorithm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
