mlibbey commented on code in PR #13370:
URL: https://github.com/apache/trafficserver/pull/13370#discussion_r3546086933
##########
plugins/prefetch/plugin.cc:
##########
@@ -851,8 +851,8 @@ TSRemapDoRemap(void *instance, TSHttpTxn txnp,
TSRemapRequestInfo *rri)
PrefetchDebug("failed to get path to (pre)match");
}
- String queryKey = config.getQueryKeyName();
- if (!queryKey.empty()) {
+ const String &queryKey = config.getQueryKeyName();
+ if (!handleFetch && !queryKey.empty() &&
getPristineUrlQuery(txnp).find(queryKey) != String::npos) {
PrefetchDebug("handling for query-key: %s", queryKey.c_str());
handleFetch = true;
}
Review Comment:
ok -- the same concept was used in a few places. Reworked in those places
too now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
