Copilot commented on code in PR #13375:
URL: https://github.com/apache/trafficserver/pull/13375#discussion_r3563128936
##########
include/cripts/Instance.hpp:
##########
@@ -106,7 +106,7 @@ class Instance
debug(fmt::format_string<T...> fmt, T &&...args) const
{
if (DebugOn()) {
- auto str = fmt::vformat(fmt, fmt::make_format_args(args...));
+ auto str = fmt::format(fmt, std::forward<T>(args)...);
Review Comment:
`Instance::debug()` now calls `fmt::format()` and uses `std::forward()`, but
`Instance.hpp` does not include `<fmt/format.h>` (for `fmt::format`) or
`<utility>` (for `std::forward`). This makes the header fragile and can break
compilation depending on include order (e.g. `cripts/Context.hpp` includes
`cripts/Instance.hpp` without pulling in `cripts/Lulu.hpp`). Add the missing
includes directly to `Instance.hpp` to make it self-contained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
