Copilot commented on code in PR #447:
URL: https://github.com/apache/trafficserver-ci/pull/447#discussion_r3572737918
##########
jenkins/github/autest.pipeline:
##########
@@ -157,7 +157,7 @@ pipeline {
# Check for parallel support in autest.sh - originally added in
10.2.0.
if grep -q parallel_mode autest.sh; then
- autest_args="-j 2 ${autest_args}"
+ autest_args="-j 2 -v ${autest_args}"
fi
Review Comment:
The feature-gate here only checks for `parallel_mode` support, but it also
unconditionally adds `-v`. If `-v` was introduced separately from parallel
mode, this can cause `./autest.sh` to fail on older branches that do support
parallel mode but not verbose, turning CI failures into false negatives.
Consider checking that the verbose flag is supported before appending it (or
document that `-v` is guaranteed whenever `parallel_mode` exists).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
