bneradt commented on code in PR #13378:
URL: https://github.com/apache/trafficserver/pull/13378#discussion_r3574405121
##########
src/iocore/net/TLSBasicSupport.cc:
##########
@@ -170,6 +172,47 @@ TLSBasicSupport::get_tls_group() const
return this->_get_tls_group();
}
+std::string_view
+TLSBasicSupport::get_tls_offered_signature_algorithms() const
+{
+ if (!this->_tls_offered_signature_algorithms.has_value()) {
+ this->_tls_offered_signature_algorithms =
+ this->_get_ssl_object() == nullptr ? "" :
this->_get_tls_offered_signature_algorithms();
+ }
+
+ return *this->_tls_offered_signature_algorithms;
+}
+
+std::string_view
+TLSBasicSupport::get_tls_negotiated_signature_algorithm() const
+{
+ if (!this->_tls_negotiated_signature_algorithm.has_value()) {
+ this->_tls_negotiated_signature_algorithm =
+ this->_get_ssl_object() == nullptr ? "" :
this->_get_tls_negotiated_signature_algorithm();
+ }
+
+ return *this->_tls_negotiated_signature_algorithm;
+}
+
+void
+TLSBasicSupport::capture_tls_offered_signature_algorithms()
+{
+ this->_tls_offered_signature_algorithms = this->_get_ssl_object() == nullptr
? "" : this->_get_tls_offered_signature_algorithms();
+}
Review Comment:
Good catch. The later capture now preserves a non-empty ClientHello-derived
value when the SSL API returns empty. I also added a regression test covering
this callback sequence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
