bneradt commented on code in PR #13324:
URL: https://github.com/apache/trafficserver/pull/13324#discussion_r3591246282
##########
tests/gold_tests/pluginTest/jax_fingerprint/jax_fingerprint.test.py:
##########
@@ -101,14 +101,15 @@ def __init__(
# HTTP/2 always runs over TLS (h2 requires TLS).
self._needs_tls = method in ('JA3', 'JA4') or http2
self._replay_file = self._choose_replay_file()
+ self._fingerprint_pattern = rf'{self._method}: [a-z0-9_-]+'
tr = Test.AddTestRun(name)
self._configure_dns(tr)
self._configure_server(tr)
self._configure_trafficserver()
self._configure_client(tr)
Test.AddAwaitFileContainsTestRun(
Review Comment:
Right. Or a partial string maybe. If you look at @moonchen 's description in
the corresponding issue, the Await succeeded, but then the ContainsExpression
failed. This patch makes the two of those to correspond to the same string so
they don't get out of sync. That seems like a reasonable thing for me to do,
we'll see whether that actually addresses the test flakiness. Sometimes
multiple incremental steps need to be done in CI over time to address flakey
issues like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
