moonchen opened a new pull request, #13407: URL: https://github.com/apache/trafficserver/pull/13407
`SslVConnOp::SSL_HOOK_OP_TERMINATE` has never been assigned to `hookOpRequested`: the commit that introduced it (TS-3006, 2014) only wrote the corresponding public value into the example plugins' own config structs, and the public `TSSslVConnOp` type that exposed it was removed in 2016 (TS-4658). No code in the tree assigns TERMINATE today: `hookOpRequested` is only ever reset to `SSL_HOOK_OP_DEFAULT` or set to `SSL_HOOK_OP_TUNNEL` (by the `ssl_multicert.config` `tunnel` option and `TSVConnTunnel()`). A hook that wants to end a handshake uses `TSVConnReenableEx` with `TS_EVENT_ERROR` instead. Drop the enumerator and its unreachable arm in `sslServerHandShakeEvent()`. No functional change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
