bneradt commented on code in PR #13422:
URL: https://github.com/apache/trafficserver/pull/13422#discussion_r3639713707


##########
include/proxy/hdrs/HTTP.h:
##########
@@ -616,10 +629,70 @@ class HTTPHdr : public MIMEHdr
   void mark_early_data(bool flag = true) const;
   bool is_early_data() const;
 
+  /** Parse an HTTP/1.x request header incrementally from a raw buffer.
+   *
+   * Parses input data into the header's request fields. Call repeatedly with 
the same @p parser
+   * until a result other than @c ParseResult::CONT is returned. When @c 
ParseResult::DONE is
+   * returned, the request method, URL, version, and header fields are set on 
this header.
+   *
+   * @param parser[in]                Parser state. Must be the same object on 
each call for a given message.
+   * @param start[in,out]             On entry, points to the first unparsed 
byte; on return,

Review Comment:
   `[in]`, etc. goes with `@param`:
   
   `@param[in]`, `@param[in,out]`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to