Copilot commented on code in PR #13448:
URL: https://github.com/apache/trafficserver/pull/13448#discussion_r3675388998
##########
tests/gold_tests/tls/tls_secret_update_default.test.py:
##########
@@ -122,7 +117,7 @@ def _add_config_reload_run(self) -> 'TestRun':
def _add_config_touch_run(self) -> 'TestRun':
'''Mark the multicert configuration for reload.'''
tr = Test.AddTestRun('Mark the multicert configuration for reload')
- tr.Processes.Default.Command = f'touch
{self._ts.Disk.ssl_multicert_yaml.AbsPath}'
+ tr.Processes.Default.Command = f'touch
{self._ts.Disk.ssl_multicert_config.AbsPath}'
tr.Processes.Default.ReturnCode = 0
Review Comment:
This test now writes and touches `ssl_multicert.config`, but the reload wait
condition below still looks for `'ssl_multicert.yaml finished loading'` in
diags.log. That string won’t match the SSL reload log line (it prints the
actual multicert config filename), so the wait run may never become Ready on
10.2.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
