JosiahWI commented on code in PR #13350:
URL: https://github.com/apache/trafficserver/pull/13350#discussion_r3682910745


##########
src/iocore/net/SSLKeyUtils.cc:
##########
@@ -188,3 +188,30 @@ set_ctx_dh(SSL_CTX *ctx, dh_key_t *pkey)
 }
 
 #endif // OPENSSL_IS_OPENSSL3
+
+bool
+use_pkey_from_file(SSL_CTX *ctx, const char *keyPath)
+{
+  ink_assert(keyPath && keyPath[0] != '\0');
+  int const result{SSL_CTX_use_PrivateKey_file(ctx, keyPath, 
SSL_FILETYPE_PEM)};
+  return 1 == result;
+}

Review Comment:
   This isn't the same as using an ENGINE; it needs to be fixed to either use 
ENGINE or PROVIDER APIs based on OpenSSL version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to