Copilot commented on code in PR #13469:
URL: https://github.com/apache/trafficserver/pull/13469#discussion_r3693402411
##########
CMakeLists.txt:
##########
@@ -314,8 +314,8 @@ if(NOT SSLLIB_IS_BORINGSSL
AND NOT SSLLIB_IS_AWSLC
AND OPENSSL_VERSION VERSION_GREATER_EQUAL "3.0.0"
)
- set(SSLLIB_IS_OPENSSL3 TRUE)
- add_compile_definitions(OPENSSL_API_COMPAT=10002 OPENSSL_IS_OPENSSL3)
+ set(SSLLIB_IS_AT_LEAST_OPENSSL3 TRUE)
+ add_compile_definitions(OPENSSL_API_COMPAT=10002
OPENSSL_IS_AT_LEAST_OPENSSL3)
Review Comment:
Renaming the compile-time macro from OPENSSL_IS_OPENSSL3 to
OPENSSL_IS_AT_LEAST_OPENSSL3 is a breaking change for any out-of-tree code
(e.g., plugins) that conditionally compiles against ATS/OpenSSL 3+ using the
old macro name. Since this macro is used in example/plugins and public-ish
code, consider keeping the old macro defined as a temporary compatibility alias
to avoid downstream build breakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
