Copilot commented on code in PR #13470:
URL: https://github.com/apache/trafficserver/pull/13470#discussion_r3695443621
##########
include/mgmt/config/ConfigReloadTrace.h:
##########
@@ -207,7 +207,7 @@ class ConfigReloadTask : public
std::enable_shared_from_this<ConfigReloadTask>
using self_type = ConfigReloadTask;
ConfigReloadTask() = default;
ConfigReloadTask(std::string_view token, std::string_view description, bool
main_task, ConfigReloadTaskPtr parent)
- : _info(State::CREATED, token, description, main_task), _parent{parent}
+ : _info(State::CREATED, token, description, main_task),
_parent{std::move(parent)}
{
Review Comment:
`std::move` is used in this header but the header does not include
`<utility>`. Relying on transitive includes can break builds depending on
include order / standard library implementation; headers should include what
they use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
