maskit commented on PR #13465: URL: https://github.com/apache/trafficserver/pull/13465#issuecomment-5164163505
@bneradt Two CMake changes: `ENABLE_QMUX` now defaults to `AUTO` instead of `OFF` — it was the only one of the QUIC-related flags that didn't auto-detect, even though `ENABLE_QUIC` already does the equivalent (auto-on once a usable backend exists). Made it consistent. `ENABLE_OPENSSL_QUIC` is gone. It turned out to be pure redundancy: `OFF` on that flag and `OFF` on `ENABLE_QUIC` produced the same binary either way, and it could never actually pick between two backends since OpenSSL-native QUIC and quiche require different, mutually exclusive TLS libraries — there was no build where both were even on the table to choose from. Current user-facing flags, post-cleanup: | Flag | Controls | Default | Needs | |---|---|---|---| | `ENABLE_QUICHE` | pulls in the quiche library | `OFF` | — | | `ENABLE_QUIC` | serve QUIC over UDP | `AUTO` | any usable backend (OpenSSL-native or quiche) | | `ENABLE_QMUX` | serve QUIC over TLS/TCP | `AUTO` | quiche, built with qmux support | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
