Copilot commented on code in PR #13477:
URL: https://github.com/apache/trafficserver/pull/13477#discussion_r3706510929
##########
CMakePresets.json:
##########
@@ -201,7 +201,9 @@
"description": "CI Pipeline config for Fedora Linux compiled with c++20",
"inherits": ["ci-fedora"],
"cacheVariables": {
- "CMAKE_CXX_STANDARD": "20"
+ "CMAKE_CXX_STANDARD": "20",
+ "CMAKE_C_COMPILER": "clang",
+ "CMAKE_CXX_COMPILER": "clang++"
Review Comment:
Hard-coding `clang`/`clang++` assumes those exact binaries are present on
the CI image and in `PATH`. If the Fedora runner provides version-suffixed
binaries (e.g., `clang-17`) or uses alternatives, this preset will fail to
configure. Consider pinning to a known compiler path/version used by the CI
image (or ensuring the CI image installs/provides `clang` and `clang++` under
those names) to make the preset robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
