bneradt commented on code in PR #13410:
URL: https://github.com/apache/trafficserver/pull/13410#discussion_r3709117055
##########
src/proxy/http/HttpTunnel.cc:
##########
@@ -1109,9 +1109,19 @@ HttpTunnel::producer_run(HttpTunnelProducer *p)
}
if (c_write == 0) {
- // Nothing to do, call back the cleanup handlers
- c->write_vio = nullptr;
- consumer_handler(VC_EVENT_WRITE_COMPLETE, c);
+ // Cache writes need a VIO even when the body is empty so that closing
the
+ // cache VC commits the response metadata instead of aborting the write.
+ if (c->vc_type == HttpTunnelType_t::CACHE_WRITE) {
+ c->write_vio = c->vc->do_io_write(this, 0, c->buffer_reader);
+ if (c->write_vio == nullptr) {
+ consumer_handler(VC_EVENT_ERROR, c);
+ } else if (c->write_vio->ntodo() == 0 && c->alive) {
+ consumer_handler(VC_EVENT_WRITE_COMPLETE, c);
+ }
Review Comment:
Agreed. CacheVC::openWriteMain() already reports VC_EVENT_WRITE_COMPLETE
when the zero-byte VIO has no remaining work, so I removed the synchronous
tunnel callback to avoid double delivery. The replay now allows the normal
asynchronous cache commit three seconds before follow-up requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
