maskit opened a new pull request, #13494:
URL: https://github.com/apache/trafficserver/pull/13494
## Description
`tls_engine_abort.test.py` calls `Test.PrepareTestPlugin(async_handshake,
ts, '-delay-ms=2000')`
unconditionally. On non-OpenSSL builds (e.g. BoringSSL) `async_handshake.so`
is
never built, so this raises `ValueError: PrepareTestPlugin: file does not
exist: ...` and the test errors out instead of skipping cleanly.
`Test.SkipUnless(...)` only registers skip conditions for the framework to
check later — it does not halt execution of the rest of the test script. So
even though the file already guards on:
```python
Test.SkipUnless(
Condition.HasOpenSSLVersion('1.1.1'),
Condition.IsOpenSSL(),
Condition(lambda: os.path.isfile(async_handshake), async_handshake + "
not found."),
)
```
the `Test.PrepareTestPlugin(...)` call still runs at load time regardless.
This is the same gap #13372 fixed in `tls_async_handshake.test.py`.
`tls_engine_abort.test.py` was added afterward from that file as a template
but didn't carry the guard over. This PR applies the same fix: guard the call
on file existence so the test skips cleanly on non-OpenSSL builds.
## Test plan
- Ran the autest on a non-OpenSSL (BoringSSL) build; test now skips instead
of erroring.
- Ran the autest on an OpenSSL build; test still runs and passes as before.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
