cmcfarlen commented on PR #13493: URL: https://github.com/apache/trafficserver/pull/13493#issuecomment-5196286560
Correction to my note above, and it changes the recommendation. I said the autest extension was the only missing piece and suggested partial-picking just `config_reload.test.ext`. That was incomplete on two counts: 1. The monitor-mode plumbing I listed as "already on 10.2.x" came from #12892 (the config-reload token model), which was indeed picked to 10.2.x as `5a9abc0630` via #13354 — so that part is right, but it is not from #13075. 2. #13075 is *not* tests-only. It also widens `ConfigContext::add_dependent_ctx()` and `ConfigReloadTask::add_child()` with a `filename` parameter and updates callers such as `SSLClientCoordinator.cc` to pass `ts::filename::SNI` / `ts::filename::SSL_MULTICERT`. 10.2.x still has the older signatures (`ConfigContext.h:173`, `ConfigReloadTrace.h:225`), so that enrichment was never picked either. So 10.2.x has the config-reload token-model feature but not its test-harness adoption or the `filename` enrichment that accompanies it. That looks like an oversight in the earlier backport rather than a deliberate scope decision, which makes picking **#13075 in full** the better fix — it restores parity with the feature already on the branch, the `filename` argument is defaulted and therefore source-compatible, and the ~20 converted tests move onto the same helper master has been exercising since June instead of leaving 10.2.x on divergent per-test reload logic. Disregard the partial-pick suggestion; a normal `cherry-pick -x` of #13075 as the prerequisite is the cleaner path. Nothing here asks for a change to this PR — flagging only so the backport ordering is clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
